-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the unknown extension callback. #7730
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhu
force-pushed
the
unknownExtCallbackEx
branch
from
July 10, 2024 17:12
d041be2
to
c810a8f
Compare
This will allow the user to pass in a context pointer. Allows them to avoid global variables. We also add unknown extensions callback when processing a CA in cert manager as CA certs can have unknown extensions as well. Fixes ZD 18252
anhu
force-pushed
the
unknownExtCallbackEx
branch
from
July 10, 2024 17:22
c810a8f
to
e581930
Compare
anhu
force-pushed
the
unknownExtCallbackEx
branch
from
July 10, 2024 20:15
f407c1e
to
6456281
Compare
retest this please |
dgarske
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. @SparkiDev please review.
SparkiDev
requested changes
Jul 22, 2024
SparkiDev
requested changes
Jul 22, 2024
SparkiDev
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the user to pass in a context pointer. Allows them to avoid global variables.
Fixes ZD 18252